Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: save project creation current step in local storage #2080

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

blushi
Copy link
Member

@blushi blushi commented Sep 6, 2023

Description

Closes: regen-network/rnd-dev-team#1574


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Create a new project from https://deploy-preview-2080--regen-marketplace.netlify.app/ecocredits/projects, or edit an existing one which is not off-chain yet.
Go through a few steps, leave the page and then come back to your projects page and edit the same project, you should be redirected to where you left off. This gets saved as soon as you submit or hit the next button.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 83e1cfd
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/64f9753d65ce7000082a23b2
😎 Deploy Preview https://deploy-preview-2080--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi blushi requested a review from a team September 6, 2023 13:14
@blushi
Copy link
Member Author

blushi commented Sep 6, 2023

@erikalogie see testing instructions above

Copy link
Collaborator

@flagrede flagrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@erikalogie
Copy link
Collaborator

LGTM

@blushi blushi force-pushed the feat-1574-create-project-current-step branch from d449be1 to 83e1cfd Compare September 7, 2023 07:01
@blushi
Copy link
Member Author

blushi commented Sep 7, 2023

re-run the storybook build on netlify by clearing the cache and it succeeded: https://app.netlify.com/sites/regen-storybook/deploys/64f97bc222182a435836ff76 but github doesn't seem to pick up this latest build in the checks.

@blushi blushi merged commit 458d80d into dev Sep 7, 2023
@blushi blushi deleted the feat-1574-create-project-current-step branch September 7, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants