fix: trigger form validation on preview photo upload #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
blushi
reviewed
Sep 5, 2023
Comment on lines
25
to
33
| // Handle old metadata schema | ||
| const previewPhoto = metadata?.['regen:previewPhoto']; | ||
| const isPreviewPhotoString = typeof previewPhoto === 'string'; | ||
| const previewPhotoUrl = isPreviewPhotoString | ||
| ? previewPhoto | ||
| : previewPhoto?.['schema:url'] ?? ''; | ||
| const previewPhotoCredit = isPreviewPhotoString | ||
| ? '' | ||
| : previewPhoto?.['schema:creditText'] ?? ''; |
There was a problem hiding this comment.
I believe we should not really support that anymore. All projects on prod should have been migrated to the latest format. But that might not be the case for all projects on staging indeed. In this case, that should be updated manually from the db rather that supported from the UI.
This brings up the need again to reset staging data (both db and redwood testnet).
There was a problem hiding this comment.
Opened an issue for further discussion: regen-network/rnd-dev-team#1784
There was a problem hiding this comment.
I can remove that logic then but yes that's the case for most of our projects on staging.
blushi
approved these changes
Sep 7, 2023
flagrede
force-pushed
the
fix-1775-submit-media-form
branch
from
1675b07 to
e86d97c
Compare
flagrede
force-pushed
the
fix-1775-submit-media-form
branch
from
e86d97c to
5b189a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: regen-network/rnd-dev-team#1775
regen:previewPhoto(string instead of object)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...