Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add project impact description #2067

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

flagrede
Copy link
Collaborator

@flagrede flagrede commented Sep 4, 2023

Description

Closes: regen-network/rnd-dev-team#1738

  • handle project-specific impact description

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. https://deploy-preview-2067--regen-marketplace.netlify.app/project/C01-001

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 224b870
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/64f9f5bc63ba0a00084c4367
😎 Deploy Preview https://deploy-preview-2067--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flagrede
Copy link
Collaborator Author

flagrede commented Sep 4, 2023

@erikalogie you can check that we now display on-chain impact descriptions for project here: https://deploy-preview-2067--regen-marketplace.netlify.app/project/C01-001

@flagrede flagrede requested a review from a team September 4, 2023 14:59
@erikalogie
Copy link
Collaborator

@flagrede this looks good!

@flagrede flagrede requested a review from blushi September 6, 2023 12:50
@flagrede flagrede force-pushed the feat-1738-project-specific-impact-desc branch from 0c80450 to 62e710e Compare September 6, 2023 14:23
@flagrede flagrede force-pushed the feat-1738-project-specific-impact-desc branch from 62e710e to 224b870 Compare September 7, 2023 16:09
@flagrede flagrede merged commit 71ec31b into dev Sep 7, 2023
14 checks passed
@flagrede flagrede deleted the feat-1738-project-specific-impact-desc branch September 7, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add project-specific impact description
3 participants