-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add testnet cmd #607
Conversation
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
==========================================
+ Coverage 74.09% 75.35% +1.26%
==========================================
Files 104 104
Lines 14899 14271 -628
==========================================
- Hits 11039 10754 -285
+ Misses 3131 2823 -308
+ Partials 729 694 -35
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK. Cross-referenced with the implementation in cosmos-sdk. Looks good! The only request would be to be to add .testnets
to .gitignore
but pre-approving.
Also, one issue with running make localnet-start
but unrelated to the implementation. It seems to be an issue using the latest libc
, which is available on Ubuntu 21.10.
Description
Closes: #563
Ref: #9246
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change