Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add testnet cmd #607

Merged
merged 12 commits into from
Nov 16, 2021
Merged

feat!: add testnet cmd #607

merged 12 commits into from
Nov 16, 2021

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Oct 29, 2021

Description

Closes: #563
Ref: #9246


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #607 (c937a3e) into master (05dfaec) will increase coverage by 1.26%.
The diff coverage is 24.26%.

❗ Current head c937a3e differs from pull request most recent head c445e0d. Consider uploading reports for the commit c445e0d to get more accurate results

@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
+ Coverage   74.09%   75.35%   +1.26%     
==========================================
  Files         104      104              
  Lines       14899    14271     -628     
==========================================
- Hits        11039    10754     -285     
+ Misses       3131     2823     -308     
+ Partials      729      694      -35     
Flag Coverage Δ
experimental-codecov 75.35% <24.26%> (+1.26%) ⬆️
stable-codecov 66.91% <21.96%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleem1314 aleem1314 marked this pull request as ready for review November 1, 2021 04:13
@ryanchristo ryanchristo assigned clevinson and ryanchristo and unassigned clevinson Nov 1, 2021
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Cross-referenced with the implementation in cosmos-sdk. Looks good! The only request would be to be to add .testnets to .gitignore but pre-approving.

Also, one issue with running make localnet-start but unrelated to the implementation. It seems to be an issue using the latest libc, which is available on Ubuntu 21.10.

Makefile Show resolved Hide resolved
@aleem1314 aleem1314 requested a review from anilcse November 12, 2021 13:36
@ryanchristo ryanchristo enabled auto-merge (squash) November 16, 2021 16:14
@ryanchristo ryanchristo merged commit b947232 into master Nov 16, 2021
@ryanchristo ryanchristo deleted the aleem/563-testnet-command branch November 16, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement testnet command
4 participants