Refactor Fixture #228
Merged
Refactor Fixture #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## marie/136-x-group #228 +/- ##
==================================================
Coverage 16.03% 16.03%
==================================================
Files 48 48
Lines 11501 11501
==================================================
Hits 1844 1844
Misses 9429 9429
Partials 228 228 |
aaronc
added a commit
that referenced
this pull request
Jan 29, 2021
* Add group module and updated proto * Delete unrelevant files * WIP on upgrade to stargate * Add TODO * Fix proto-gen * Fix group AppModule and AppModuleBasic * More migration in x/group * Fix lint * More lint fix * Rename GroupID * Fix TestGroupMetadataValidation and add UnpackInterfaces * Refacto to use Msg services * Move module impl to x/group/module and remove amino * Fix build * Fix lint * Clean up testutil * Add Proposal and CreateProposal rpc, use Any for msgs in it * Fix lint * Fix initParamsKeeper * Comment group ref in app * Add comments in proto * gen proto * wip on tests * Setup test suite * Rm keeper_test * Rm testsupport.go * Move old hander tests to testsuite and use msgClient in tests * Use BinaryMarshaler in ORM to unpack Any's * Fix exec proposal tests * Fix group tests * Add proposal executor tests * Update ORM tests * Wire up group module to regen app * Fix lint * Fix proto lint * Renaming * Update ORM * Remove errors pkg * Improve proposal doc * Fix events types * Update comment * Clean up * Use GroupId * Use ProposalId * Update conditions.go * Rename to GetGroupMembers * Add assertCommentSize * Update x/group/server/keeper.go Co-authored-by: Robert Zaremba <[email protected]> * Update x/group/server/keeper.go Co-authored-by: Robert Zaremba <[email protected]> * Rename result enum value * Add doc * Add doc * Use apd.Decimal instead of sdk.Dec * Rename to GroupInfo and GroupAcountInfo * Move group/types to group * Remove tmp query.proto * Move Keeper methods to serverImpl * Add Query service proto def * Add first impl of query service * Finish up query service and rm keeper * Lint * Rename GroupID to ID * Support Key page request with index.Get * Lint * Format * Use bech32 addresses * Lint * Update group events * Refactor group module to work with new proto codegen * Lint * Update protocgen script * Update proto/regen/group/v1alpha1/genesis.proto Co-authored-by: Anil Kumar Kammari <[email protected]> * Update proto/regen/group/v1alpha1/query.proto Co-authored-by: Anil Kumar Kammari <[email protected]> * Update proto/regen/group/v1alpha1/events.proto Co-authored-by: Anil Kumar Kammari <[email protected]> * Update x/group/README.md Co-authored-by: Anil Kumar Kammari <[email protected]> * Update testutil/testdata/tx.proto Co-authored-by: Anil Kumar Kammari <[email protected]> * Address review comments * Update README.md * Reference issues in todos * Rename member's weight variables * Update x/group/server/msg_server.go Co-authored-by: Anil Kumar Kammari <[email protected]> * Update x/group/README.md Co-authored-by: Aaron Craelius <[email protected]> * Update AccAddresses ValidateBasic * Remove useless address var * Reference event issue * Add comment in Vote * Update x/group/README.md Co-authored-by: Aaron Craelius <[email protected]> * Update x/group/README.md Co-authored-by: Aaron Craelius <[email protected]> * Add GetPaginated to orm Index * Rename var in orm/iterator * Replace comment with metadata * More renaming * Support only one voter per Vote request * Use fixed MaxMetadataLength * Migrate group module to use ADR 033 and update GroupMember type * Link * Reorder members in test to compare * Rename perm to conditionFormat * Update x/group/conditions.go Co-authored-by: Robert Zaremba <[email protected]> * Add Paginate doc * Update orm/iterator.go Co-authored-by: Robert Zaremba <[email protected]> * Update doc * Add more docs * More docs * Add more tests for GetPaginated * Add err check in assertion * Always handle errors in Paginate loop * Add more comments to Paginate * Move destRef.Set to end of loop * Add more tests cases for Paginate * Update proto/regen/group/v1alpha1/tx.proto Co-authored-by: Anil Kumar Kammari <[email protected]> * Update proto/regen/group/v1alpha1/types.proto * Refactor Fixture (#228) * Address some of review comments * Address comments and add more docs * Update x/group/server/msg_server.go Co-authored-by: Aaron Craelius <[email protected]> * Update x/group/server/msg_server.go Co-authored-by: Aaron Craelius <[email protected]> * Update comment * Update proto/regen/group/v1alpha1/query.proto Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Anil Kumar Kammari <[email protected]> Co-authored-by: Aaron Craelius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.