Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge v0.46.7-regen-2 into release/v0.46.11-regen #53

Merged
merged 14 commits into from
Mar 23, 2023

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Mar 23, 2023

Description

This pull request merges the v0.46.7-regen-2 release into the new v0.46.11 release branch (created from v0.46.11).

(1) created release/v0.46.11-regen from v0.46.11
(2) created feature branch from release/v0.46.11-regen
(3) pulled release tag v0.46.7-regen-2 into feature branch
(4) resolved conflicts favoring v0.46.7-regen-2 changes (snapshot changes required with go 1.19)
(5) removed lingering test file no longer relevant to latest version


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

ryanchristo and others added 12 commits December 12, 2022 11:23
* fix!(group): Register types with Amino

* Chagenlog
* fix!: Fix gov amino codec

* changelog
* fix!: Fix group amino codec

* changelog
* Make extension snapshotter interface safer to use

Closes: cosmos#11824
Solution:
- Use new methods `SnapshotExtension`/`RestoreExtension` to handle payload stream specifically.
- Improve unit tests.

* update changelog

* Update snapshots/types/util.go

* changelog

* go linter

* Update CHANGELOG.md

Co-authored-by: Aleksandr Bezobchuk <[email protected]>
fix: gov and group amino and snapshot hashes
feat(gov): support v1.Proposal in v1beta1.Proposal.Content
@ryanchristo ryanchristo force-pushed the ryan/v0.46.11-regen-merge branch from a3aa11e to 7c281e9 Compare March 23, 2023 17:08
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql-analysis.yml:analyze. As part of the setup process, we have scanned this repository and found 323 existing alerts. Please check the repository Security tab to see all alerts.

@ryanchristo ryanchristo force-pushed the ryan/v0.46.11-regen-merge branch from c7bccf0 to 49c63c0 Compare March 23, 2023 17:30
@ryanchristo ryanchristo force-pushed the ryan/v0.46.11-regen-merge branch from 49c63c0 to ada9ab4 Compare March 23, 2023 17:33
@ryanchristo ryanchristo marked this pull request as ready for review March 23, 2023 18:17
@ryanchristo ryanchristo requested a review from clevinson March 23, 2023 18:17
@ryanchristo
Copy link
Member Author

Re-running failed workflow task to see if intermittent.

@ryanchristo
Copy link
Member Author

Re-running failed workflow task (different test) to see if intermittent.

@ryanchristo
Copy link
Member Author

All tests passed now. I think these integration tests are unreliable and seems relevant to cosmos#14145.

@ryanchristo ryanchristo merged commit 58d2f5a into release/v0.46.11-regen Mar 23, 2023
@ryanchristo ryanchristo deleted the ryan/v0.46.11-regen-merge branch March 23, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants