Add env variable to disable version check

regadas · Nov 18, 2020 · f29ff0e · f29ff0e
1 parent 828dca9
commit f29ff0e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/ci-it.yml b/.github/workflows/ci-it.yml
@@ -4,6 +4,7 @@ env:
   ENCRYPTION_KEY: ${{ secrets.ENCRYPTION_KEY }}
   GOOGLE_APPLICATION_CREDENTIALS: scripts/gha-data-integration-test.json
   GOOGLE_PROJECT_ID: data-integration-test
+  SCIO_IGNORE_VERSION_WARNING: true
 
 on: push
 

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -1,6 +1,7 @@
 name: ci
-
 on: [push, pull_request]
+env:
+  SCIO_IGNORE_VERSION_WARNING: true
 
 jobs:
   checks:

diff --git a/scio-core/src/main/scala/com/spotify/scio/VersionUtil.scala b/scio-core/src/main/scala/com/spotify/scio/VersionUtil.scala
@@ -80,7 +80,10 @@ private[scio] object VersionUtil {
   }
 
   private[scio] def ignoreVersionCheck: Boolean =
-    Option(System.getProperty("scio.ignoreVersionWarning")).exists(_.trim == "true")
+    sys.props
+      .get("scio.ignoreVersionWarning")
+      .orElse(sys.env.get("SCIO_IGNORE_VERSION_WARNING"))
+      .exists(_.trim == "true")
 
   private def messages(current: SemVer, latest: SemVer): Option[String] = (current, latest) match {
     case (SemVer(0, minor, _, _), SemVer(0, 7, _, _)) if minor < 7 =>