Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: final v0 (plus) API and spec #7

Merged
merged 14 commits into from
Oct 24, 2023
Merged

update: final v0 (plus) API and spec #7

merged 14 commits into from
Oct 24, 2023

Conversation

gaukas
Copy link
Contributor

@gaukas gaukas commented Oct 23, 2023

No description provided.

@gaukas gaukas added the WATMv0 This impacts WATM Spec v0 only label Oct 23, 2023
@gaukas gaukas mentioned this pull request Oct 23, 2023
Closed
@gaukas
update: ci and readme
78e03aa 
- Update CI to fail fast. Add `golangci-lint` to CI.
- Update full name WebAssembly Transport Executables Runtime. Update badges.
@gaukas
Copy link
Contributor Author

gaukas commented Oct 23, 2023

Well I guess golangci-lint has much stricter criteria than deep source. I may use some help in addressing some of those reported errors.

jmwample and others added 3 commits October 23, 2023 17:56
@jmwample
satisfy the linting gods
0422575
@deepsource-autofix
style: format code with Gofumpt
b6146a8 
This commit fixes the style issues introduced in 0422575 according to the output
from Gofumpt.

Details: #7
@jmwample
readme pass
00c36b2
jmwample
jmwample approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@jmwample jmwample left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if I would call this completely final. But I think this is a huge step towards v0(+) and I am happy with where this PR is. Other issues might be addresses separately.

@gaukas
Copy link
Contributor Author

gaukas commented Oct 24, 2023

Looks good. I may open a PR later this week to work around the conn halting bug with a more graceful solution which utilizes cancel channel. But otherwise everything look good to me now. Thanks to @jmwample for helping out.

erikziyunchi
erikziyunchi approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@erikziyunchi erikziyunchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well! Thanks for the detailed updates!

@gaukas gaukas merged commit ec4b9f1 into master Oct 24, 2023
8 checks passed
@gaukas gaukas deleted the v0-plus branch November 28, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikziyunchi erikziyunchi erikziyunchi approved these changes

@jmwample jmwample jmwample approved these changes

@ewust ewust Awaiting requested review from ewust

Assignees
No one assigned
Labels
WATMv0 This impacts WATM Spec v0 only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaukas @jmwample @erikziyunchi