Version 0.1.6 #34
Merged
Version 0.1.6 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Reflux.all to track the status of multiple listenables. All listenables must have emitted at least one. Fixes #27
This was referenced Aug 5, 2014
| function didAllListenablesEmit() { | ||
| // reduce cannot be used because it only iterates over *present* | ||
| // elements in the array. Initially the Array doesn't contain | ||
| // elements. Fore this reason the usage of reduce would always indicate |
|
|
||
| for (; i < args.length; ++i) { | ||
| listener = args[i]; | ||
| if (listener === listener) { |
There was a problem hiding this comment.
listener === listenerEh, "derp" on my behalf.
|
@KyleAMathews, @dashed Done. I'll be releasing this tomorrow after I got some sleep if nobody objects. :-) |
|
Looks great, thanks for the release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging in #27 and #33.
Should also fix #26.