update fileinput example to allow newer reflex #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fileinput example compiled with ghcjs but not with ghc nor ghcid. Thus, liftIO's were changed to liftJSM's (three changes).
It also seems that the return type
getResult
has changed causing a small modifications following line 53. ThefromJSVal <=< toJSVal
construction is something that bothers me a bit: can the compiler optimize that and is there a function that would do the transformation directly? (Or is this the way to do in this kind of situations?)At the end the
return
can be simplified a bit as the transformation can give directlyText
.