benchmarks.yml: use node 18.x with reflex-web@main #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse requires node 18.x Target the reflex-web main branch for better tracking of lighthouse scores over time.
ElijahAhianyo
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lighthouse requires node 18.x
Target the reflex-web main branch for better tracking of lighthouse scores over time.
👉 Test run: https://github.com/reflex-dev/reflex/actions/runs/9882217403/job/27294653882
Sidenote
We actually haven't passed lighthouse benchmarking since late April 2024, but almost no one notices because it runs on the PR after the PR is closed. So only the submitter or the merger will get an email notification about the benchmarking failures so basically it fails silently. If you check the merged PR list lately, all of them have ❌ even though they were ✅ when we merged them.
Today i got sick of getting these failure emails, and lighthouse benchmarking per-pr is probably something we do want, so... here we are.