Catch unhandled errors on both frontend and backend #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rx.App - wrapped the app with ErrorBoundary component to catch rendering errors
maximvlah
changed the title
|
@maximvlah reflex-web ci is failing |
- minor refactoring of error boundary - removed error boundary from 404 page
|
@Lendemor @masenf @picklelo @ElijahAhianyo could someone be so kind and review this one? It would be awesome to also get some thoughts on @maximvlah's comment here: #3476 (comment) |
|
Will review/test it this week. |
* Remove custom _render function * Remove special imports in Component base class * Simplify hooks for better composability
Lendemor
approved these changes
Jul 5, 2024
benedikt-bartscher
approved these changes
Jul 6, 2024
masenf
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #3476
closes #3284