[REF-1368] Move common form functionality to rx.el.forms #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow plain HTML Form element to have magic on_submit event handler.
Consolidate logic in the basic HTML form and use it in both Radix and Chakra form wrappers.
picklelo
approved these changes
Mar 7, 2024
| @overload | ||
| @classmethod | ||
| def create( # type: ignore | ||
| cls, | ||
| *children, | ||
| as_: Optional[Union[Var[str], str]] = None, | ||
| accept: Optional[ |
There was a problem hiding this comment.
Do we want to keep all these other props also, do they work? We could delete them in the base el.Form, I think it may add more noise/clutter than benefit
There was a problem hiding this comment.
The radix form for sure supports all of the native HTML Form props... chakra, i'm less sure about. At any rate, i don't think these will show up in the API docs, but I'll check before merging
There was a problem hiding this comment.
The base form props are not rendering in the API docs. going ahead with the merge.
|
Hi, the |
mahrz24
pushed a commit
to mahrz24/reflex
that referenced
this pull request
Mar 12, 2024
…2801) * [REF-1368] Move common form functionality to rx.el.forms Allow plain HTML Form element to have magic on_submit event handler. * Chakra and Radix forms inherit `on_submit` functionality from rx.el.form Consolidate logic in the basic HTML form and use it in both Radix and Chakra form wrappers. * from __future__ import annotations for py38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow plain HTML Form element to have magic on_submit event handler.
Chakra and Radix forms inherit on_submit functionality from rx.el.form
Consolidate logic in the basic HTML form and use it in both Radix and Chakra form wrappers.
Update
test_form_submit.pyRun the integration test with all three types of form roots to ensure consistent behavior.