docker-example overhaul #2690
Merged
docker-example overhaul #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update docker-example with a more realistic multi-compose deployment, and also a more simplistic single-image deploy. * Use `uv` for faster bootstrapping * Separate simple and production-ready docker files * Split compose.yaml into 3 parts * Persist sqlite db and tls keys * Include postgres and redis * Include Adminer and redis-commander for adminstration * Suppose upload persistence * Update documentation * Update Caddyfile for compatibility with new Upload API
Pre-pack the resulting image with npm dependencies to reduce startup time
picklelo
reviewed
Feb 27, 2024
docker-example/Dockerfile
Outdated
|
|
||
| # Pass `--build-arg API_URL=http://app.example.com:8000` during build | ||
| ARG API_URL | ||
| ARG uv=/root/.cargo/bin/uv |
There was a problem hiding this comment.
Should we focus on simplicity for this Dockerfile and use just the basic tools? I think it would be nice if the base one we had just minimized lines of code to get it working, and we can have another more optimized one.
There was a problem hiding this comment.
changed to just using pip
picklelo
requested changes
Mar 4, 2024
picklelo
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docker-example with a more realistic multi-compose deployment, and also a more simplistic single-image deploy.
uvfor faster bootstrappingHave a go with my test app: https://github.com/masenf/repro-datetime-model/tree/main