Add ability to translate image_title and image_alt fields #2965
Conversation
bricesanchez
force-pushed
the
feature-translate-images
branch
from
e6147c3 to
d50ecad
Compare
| @@ -19,6 +19,12 @@ def thumbnail_urls(image) | |||
|
|
|||
| thumbnail_urls | |||
| end | |||
|
|
|||
| # We show the title from the next available locale | |||
| # if there is no title for the current locale | |||
There was a problem hiding this comment.
I'm not sure if this is what users wants everytime.
There was a problem hiding this comment.
There was a problem hiding this comment.
So, this method is not good too : https://github.com/refinery/refinerycms/blob/master/pages/app/helpers/refinery/admin/pages_helper.rb#L50 ?
There was a problem hiding this comment.
Do you have any clue to fix this?
There was a problem hiding this comment.
We do that on the backend because otherwise it is simply blank, but we don't want to display wrong content on the frontend. Maybe we should write the pages one better too.
There was a problem hiding this comment.
At this time we only use image_title_with_translations method in backend.
bricesanchez
force-pushed
the
feature-translate-images
branch
2 times, most recently
from
7dbb04c to
180446e
Compare
| let(:gridview_title_selector) {'[tooltip]'} | ||
| let(:gridview_alt_selector) {'[alt]'} | ||
| let(:listview_title_selector) {' > span.title'} | ||
| let(:listview_filename_selector) {' > span.preview'} |
There was a problem hiding this comment.
this changeset is a great example of why aligning things isn't ideal 😄
There was a problem hiding this comment.
Yeah, good to know :)
|
@parndt Are you ok to merge this PR ? |
|
I note there are no tests specific to this feature? |
|
Is someone could help me to test this PR ? |
parndt
force-pushed
the
feature-translate-images
branch
from
180446e to
a531e3b
Compare
|
@anitagraham do you have any ideas? I know you've been working on images specs lately. |
|
Yes, having a look at how the translations for page title are tested. |
|
Thanks @anitagraham, it's really appreciated! |
|
So, to confirm: is the point of this feature so that the user can avoid uploading an image per locale? |
|
Yes. |
|
i will update this really soon PR :) |
bricesanchez
force-pushed
the
feature-translate-images
branch
from
a531e3b to
54f4018
Compare
bricesanchez
changed the title
bricesanchez
force-pushed
the
feature-translate-images
branch
from
54f4018 to
b22eab5
Compare
bricesanchez
changed the title
|
It's ready @parndt :) |
| end | ||
|
|
||
| def self.down | ||
| Refinery::Image.drop_translation_table! migrate_data: true |
|
@bricesanchez sorry, I missed the migration problems before 😦 |
bricesanchez
force-pushed
the
feature-translate-images
branch
from
b22eab5 to
73cbef5
Compare
|
@parndt no problems, is it ok like that now? |
|
OK, I'm happy with this. |
Add ability to translate image_title and image_alt fields
No description provided.