Migration to Dragonfly ~> 1.0.0.

[simi]

What wasn't tested:

• S3 integration
• acts_as_indexed integration

pingie @ugisozols @parndt

[simi]

Maybe deprecation will be better to avoid error raising?

[parndt]

This is 3.0 so it's not that much of a problem. Everyone who is using this is on the edge, so... it depends.

[simi]

It's pain to migrate every refinery version to another refinery version. Let's start keeping it less painful and more friendly.

[parndt]

OK, that sounds good. So, Refinery.deprecate it is?

[simi]

Yup. I'll change that later. 😴

[simi]

I made few updates. I left it in separeted commit for easy review. I'll fixup this before merging.

[parndt]

Is this ready to go, in your opinion?

[simi]

Not yet. I need to test it.

[simi]

@parndt I'm getting some issues with refinery-acts-as-indexed master. Bundler can't resolve deps. :( So I can't test it.

[parndt]

@simi I'll take a look

[simi]

☕ for you.

[parndt]

I get no issues with bundling your fork/branch, but maybe try a) rebasing this pull request against the current refinery/refinerycms and b) get the latest commits to refinery/refinerycms-acts-as-indexed@aa7862f then run bundle update :)

[simi]

Shame on me. I was using old refinery/refinerycms-acts-as-indexed 👎

[simi]

Hmm, are getting this also? I pointed to this branch (both, testing and refinerycms)

[retro@localhost  refinerycms-acts-as-indexed (master *=)]❤ bundle exec rake refinery:testing:dummy_app
rake aborted!
undefined method `load_tasks' for #<Refinery::Testing::Railtie:0x00000001d47d70>
/home/retro/.rvm/gems/ruby-2.0.0-p353/gems/railties-4.0.2/lib/rails/railtie/configurable.rb:30:in `method_missing'
/home/retro/work/fun/refinerycms-acts-as-indexed/Rakefile:16:in `<top (required)>'
(See full trace by running task with --trace)

diff --git a/Gemfile b/Gemfile
index 71beeb5..6713051 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,13 +2,12 @@ source 'https://rubygems.org'

 gemspec

-git 'git://github.com/refinery/refinerycms.git', :branch => 'master' do
-  gem 'refinerycms'
+gem 'refinerycms', path: '../refinerycms'

-  group :development, :test do
-    gem 'refinerycms-testing'
-  end
+group :development, :test do
+  gem 'refinerycms-testing', path: '../refinerycms'
 end
+
 gem 'refinerycms-i18n', github: 'refinery/refinerycms-i18n', branch: 'master'
 gem 'mime-types', '~> 1.16'

[parndt]

Yeah, that's due to old code. I'm currently fixing this, or trying!

[parndt]

Try with refinery/refinerycms-acts-as-indexed@231d35d

[simi]

OK, let's go thru CI and I'll rebase into one commit. It will be ok to merge in master, but please don't release yet. I tested acts-as-indexed, so it works as before.

[simi]

@parndt 🍏

[simi]

Failing test fixed here maybe - #2512. @parndt

[parndt]

@simi I merged your CI pull request

[simi]

@parndt so?

[parndt]

@simi I'm happy but the PR is saying it cannot be automatically merged. Can you rebase the branch please?

[simi]

[parndt]

Thank you!!!!!!

[simi]

[parndt]