Add actual support for turning the welcome page off or on

[dchapman1988]

The guides suggest if you're using an existing application with devise you can add the show_welcome_page? method to your application controller and tell it to return false it will keep the welcome page from showing. Needless to say, this wasn't a thing. I've made this a thing. It's now a core refinery setting.

[gwagener]

This method name is disingenuous as it does not return a boolean or even truthy value. Perhaps it should be create_refinery_user_if_required or similar.

[parndt]

Or redirect_if_refinery_user_required!

[parndt]

Or require_refinery_user!

[gwagener]

Last ones seems best.

[parndt]

We removed it from ApplicationController in master, it's just a thing
in the AdminController now. Plus I am not sure this should be a core
setting... it's so very easy to just override the method.

[gwagener]

@parndt Do you mean override show_welcome_page? or refinery_user_required?? If you mean show_welcome_page? then the problem is that that method is never called so the changes for refinery_user_required? are still required.

[parndt]

I think here you could just use:

delegate :show_welcome_page?, :to => Refinery::Core, :prefix => nil

Or

delegate :show_welcome_page, :to => Refinery::Core, :prefix => nil
alias_method :show_welcome_page?, :show_welcome_page

Or no?

[dchapman1988]

Possibly... I haven't tried. The logic behind putting it here was that the guide instructs you to put it in your application controller (as if it's going to override the same method in Refinery's application controller). It turns out by doing this, what the guide tells you to do actually works.

[parndt]

Please see my refactoring in #2076 too.

[gwagener]

Ok, the state of affairs is that this functionality has been changed slightly on master and the docs are incorrect for master and 2-0-stable. The functionality and naming on master are good and don't need a configuration to make things easier to understand. 2-0-stable shouldn't be adding new features anyway. Therefore, I think the best course of action related to this pull request is to just change the documentation. I imagine something like:

We need to also avoid the show_welcome page in test mode or our ExistingApp existing integration tests will suddenly stop working.

NOTE: For branch @2-0-stable@ the relevant method is @refinery_user_required?@ in @app/controllers/application_controller@
<ruby>
class ApplicationController < ActionController::Base
  ...
  def refinery_user_required?
    false
  end
  ...
end
</ruby>

NOTE: For branch @master@ the relevant method is @require_refinery_users!@ in @app/controllers/refinery/admin/base_controller@
<ruby>
class Refinery::Admin::BaseController
  ...
  def require_refinery_users!
    false
  end
  ...
end
</ruby>

Ok. We should be ready to give it a spin.

The intro sentence about this being for testing might need to be changed too. For tests it's easy enough to achieve the same result with a stub.

[parndt]

Looks good except require_refinery_users! doesn't apply to ApplicationController; it applies to Refinery::AdminController :-)

Refinery users aren't required on the frontend anymore from 2.1.0 ->

Those notes would read better if you said "on versions before 2.1.0" and "on versions 2.1.0 and onward" so that people don't go "I'm not using git branches".

Good summary, thanks!