Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial custom backend route config. #2050

Closed
wants to merge 1 commit into from

Conversation

simi
Copy link
Member

@simi simi commented Nov 27, 2012

Requested by @Marshy on IRC.

@ugisozols
Copy link
Member

It's not that simple. There are things that depend on /refinery to be in the path like for example routing filter.

This could be the starting point but there's definitely a lot of work still to be done.

@simi
Copy link
Member Author

simi commented Nov 27, 2012

I know @ugisozols. In best way it will be nice to split frontend and backend and mount them separately.

@@ -43,4 +43,7 @@ Refinery::Core.configure do |config|

# Register extra stylesheet for backend (optional options)
# config.register_stylesheet "custom", :media => 'screen'

# Specify own backend path. Default is to refinery.
# config.backend_route = 'retro'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other issues aside, this should be

# config.backend_route = <%= Refinery::Core.backend_route.inspect %>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, my lord.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we don't need to say "Default is to refinery" because it will be shown :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally understand.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased @parndt .

@parndt
Copy link
Member

parndt commented Dec 5, 2012

This is a step in the right direction - thanks!

@parndt parndt closed this in a31e589 Dec 5, 2012
ugisozols added a commit that referenced this pull request Dec 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants