Fixes GH-1892 by properly updating the form action when the title is changed during save-and-continue #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <%= value %> | ||
| <%= link_to t(".close#{'_this_message' if key.to_s == "message"}"), "", | ||
| :id => "flash_close" %> | ||
| </div> |
There was a problem hiding this comment.
indentation doesn't match opening <div
… for save-and-continue editing.
|
Looking good. @tsemana will you tackle preview bug we were talking about in irc? |
|
Thanks, yes I will. It's weird in that the regression spec I wrote works passes even though it fails when done manually... Either way I'll give it a crack |
|
Merged to 6d5c910 thanks! |
ugisozols
added a commit
that referenced
this pull request
Sep 19, 2012
ugisozols
added a commit
that referenced
this pull request
Sep 19, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes the
admin_pages_path urlusing the items current title back to the view using a hidden field tag. The save-and-continue javascript then updates the form action with the new url.Includes request spec for the first save-and-continue and regression test for the bug described in GH-1892.