Engine generator fix

[jipiboily]

I fixed then engine generation of a view that had an hardcoded "title" attribute in it.

Was generated before (line 8):

<% if translation.title.present? %>

Now:

<% if translation.[my_attribute].present? %>

ie:

<% if translation.job_title.present? %>

I also removed some code duplication to keep that DRY.

[travisbot]

This pull request passes (merged 8a46207 into 332b512).

[ugisozols]

This change will generate invalid code in case there's no string attribute - it'll just generate code like engine_name.

Current implementation will also generate absurd code if there's no string attribute like engine_name.title which will fail with undefined method 'title' for ... so this needs to fixed in either case.

[jipiboily]

True.

Is there something to do about that? We're not to display text fields or date fields in the index, right? ;)

Open to suggestions.

[ugisozols]

I was thinking about grabbing first attribute from the list in case there are no string ones. WDYT?

[jipiboily]

Great, I'll fix that soon

[ugisozols]

Thank you very much ❤️

[ugisozols]

Summoning @parndt

[jipiboily]

There seems to be a lot of things that break if there is no string...

1. the :title_attribute is not generated
2. if the first attribute (attributes.first.name) is not translated, it just doesn't show anything on index. (http://cl.ly/1y0S0V0f1S2f0I1W1c0t)
3. probably more, it was just within a few minutes! ;)

[jipiboily]

if we still want to use that, here is new first line of that file:

<% title_attribute = (title = attributes.detect { |a| a.type.to_s == "string" }).present? ? title.name : attributes.first.name %>

[ugisozols]

I'll try to dig into this tomorrow as I'm starting to feel a bit sleepy.

[parndt]

It's supposed to use .title when there are no strings. It then creates def title in the model which prints a string telling you to override it.

[jipiboily]

@parndt interesting...it crashed for me today when creating a new engine/extension...I'll try to take a look at that when I got some time.

[parndt]

@jipiboily thanks

[parndt]

This pull request seems great.

[ugisozols]

@parndt iirc this pr wasn't ready to be merged. Main reason being this - "This change will generate invalid code in case there's no string attribute - it'll just generate code like engine_name."