Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refinerycms-core depends on coffee-rails, forcing JS runtime to be needed #1975

Closed
krbullock opened this issue Sep 28, 2012 · 3 comments
Closed

Comments

@krbullock
Copy link

The refinerycms-core gem depends on coffee-rails, which in turn depends on execjs. This makes it impossible to deploy a Refinery app to a production server without a Javascript runtime. It probably also means that if you just uncomment the therubyracer dependency in the assets group, then try to deploy using bundle install --without development:test:assets, execjs won't be able to find a runtime.

I imagine that the coffee-rails dependency is there because the app generator is in -core, but does generating an app really require coffeescript? It seems like that would only be needed when compiling assets.

If the dependency can't safely be removed, the things in -core which require it could be moved into a separate gem that can require coffee-rails, leaving -core with no dependency on JS.

@parndt
Copy link
Member

parndt commented Sep 29, 2012

We need it for the coffeescript files. But it only needs to be in the
assets group of the app's Gemfile. Could you please fix this for
master? You will need to update the edge template.

@ugisozols
Copy link
Member

Merged in 6f0ee74.

@ilikepi
Copy link

ilikepi commented Feb 28, 2013

Is there any chance this could be backported into 2-0-stable? It's rather inconvenient that the latest gem release still has this dependency, and the change itself seems simple enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants