Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Username uniqueness should be checked case-insensitively #1703

Closed
kenips opened this issue May 25, 2012 · 1 comment
Closed

Username uniqueness should be checked case-insensitively #1703

kenips opened this issue May 25, 2012 · 1 comment

Comments

@kenips
Copy link

kenips commented May 25, 2012

Username should be checked for uniqueness case-insensitively. That would prevent the system erroring out on Users#edit trying to edit the wrong user.
@parndt
Copy link
Member

parndt commented May 26, 2012

👍

@parndt parndt closed this as completed May 26, 2012
ghoppe pushed a commit to ghoppe/refinerycms that referenced this issue May 28, 2012
@parndt @ugisozols
Fixes refinery#1703 by downcasing usernames before saving them.
30c4ef4 
Note: This has the implication that all usernames will now be stored downcased.

Conflicts:

	authentication/app/models/refinery/user.rb
	changelog.md
ghoppe pushed a commit to ghoppe/refinerycms that referenced this issue May 29, 2012
@parndt
Fixes refinery#1703 by downcasing usernames before saving them.
05d0d1d 
Note: This has the implication that all usernames will now be stored downcased.
ghoppe pushed a commit to ghoppe/refinerycms that referenced this issue May 29, 2012
@ugisozols
Merge pull request refinery#1704 from resolve/username_uniqueness_cas…
629b03e 
…e_insensitivity

Fixes refinery#1703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parndt @kenips