Git block remapper script #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iakinsey
approved these changes
Oct 26, 2020
api/utils/ngrok.py
Outdated
| stdout, tmp = process_handler.communicate() | ||
| stdout, stderr = process_handler.communicate() | ||
| print("ngrok stdout: ", stdout) | ||
| print("ngrok stderr: ", stderr) |
There was a problem hiding this comment.
that's a good point. I added these because I was trying to debug, and then I realized that they only print when there is an error. So I went ahead and left them. I can move to logit though!
| @@ -329,11 +329,11 @@ export class EditLambdaBlock extends Vue implements EditBlockPaneProps { | |||
| max={inputProps.max} | |||
| min={inputProps.min} | |||
| step={inputProps.step} | |||
| {...inputProps} | |||
There was a problem hiding this comment.
Why did this argument move?
There was a problem hiding this comment.
Bumped up the version of Typescript and it found this was a bug (it was, kind of). I had to move this for the app to even compile.
| const response = await importRawProjectJson(config.json, false); | ||
|
|
||
| // Attempt to make the project with a stupid and unique name. | ||
| if (response && response.code === 'PROJECT_NAME_EXISTS') { |
There was a problem hiding this comment.
Should 'PROJECT_NAME_EXISTS' be a global constant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in the
front-endfolder are all re-organizing imports to avoid importing assets (css and png files). Webpack handles those files, and Typescript cannot.Besides that, the actual "meat" of this PR is the
tweak-uuids-git.tsfile and is fairly straightfoward.Most of the work was wrangling Typescript to work with the existing code setup (which leverage Webpack for module resolution) and refactoring imports to break the import chain away from the assets.
Otherwise, yeah, the tool to rewrite the Block UUIDs for a given Git project is very simple. We should figure out how we can fix this going forward in a cleaner way that doesn't require us manually checking out a customer Git repo and making a commit in it.