Only expand Checks list on PRs, not in popups

[jameschensmith]

Summary

Expands only the PR merge status list (and not the popups/dropdowns) to fit all items. This can be thought of as a fix for the popups/dropdowns.

Test URL(s)

• dropdown(s) (main)
• dropdown(s) (commit history)
• pull request

Screenshot(s)

Long merge status list fixed

References

Fixes #4124.

[fregante]

On second thought:

• on the PR page, the section is part of the normal flow of the page, so I feel it's perfectly fine to leave it as infinite. It's already togglable, so it's doesn't make sense to limit it in anyway.
• the popup’s awkwardly extends past the natural height of the page, so it makes sense to shorten that.

Maybe we can avoid changing the popup’s height altogether, and only leave max-height: none on the PR

[fregante]

Suggested change

	/* Expand merge status lists to fit more items */
	.branch-action-item-simple > .merge-status-list, /* Dropdowns */
	.branch-action-item.open > .merge-status-list { /* Pull requests */
	max-height: 512px !important;
	/* Expand PR merge status list to fit more items */
	:root .branch-action-item.open > .merge-status-list {
	max-height: none;

We use :root to avoid !important, which is harder to override by the user.

[jameschensmith]

Ahh, okay. I saw the other !important uses and compared it to this single use of :root, and thought that was the desired route 😅 I'll address this 👍

[jameschensmith]

On second thought:

• on the PR page, the section is part of the normal flow of the page, so I feel it's perfectly fine to leave it as infinite. It's already togglable, so it's doesn't make sense to limit it in anyway.
• the popup’s awkwardly extends past the natural height of the page, so it makes sense to shorten that.

Maybe we can avoid changing the popup’s height altogether, and only leave max-height: none on the PR

Okay, so it sounds like we should just keep what we have for the PR page, and filter out the dropdown/popup. I understand your request 😊 👍 I'll do my best to figure that out and get the change in!

[jameschensmith]

Updated the PR, title, and description to reflect the new request. This now covers addressing the popups/dropdowns, while keeping the PR merge status list infinite.

[fregante]

Thank you for the PR and for following its template, James! 😁 🥨