-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for logged out 404 pages #174
Conversation
Note that logged out pages are generally not supported by Refined GitHub and we don't add extra code to support them. This PR can be an exception to that rule |
Should I add any tests? I didn't find any for the |
Line 71 in b6f7b8d
|
I think the last test will fail now since we also check for Line 81 in b6f7b8d
|
The tests are not failing in the current PR |
Oh right lol |
- make sure the `File not found · GitHub` case works too
Overview
When logged in and in the file tree, GitHub changes the page title to
File not found
if the requested file/folder is missing.However, when logged out or an issue/pr is not found, the page title is changed to
Page not found
.This PR updates the
is404
function to reflect the above change.Test URLs