Skip to content

Commit

Permalink
assert: refactor to reduce unecessary code paths
Browse files Browse the repository at this point in the history
The lazy loading is not needed as the errors themself lazy
load assert. Therefore the circle is working as intended
even without this lazy loading.

Improve Array, object, ArrayBuffer, Set and Map performance
in all deepEqual checks by removing unecessary code paths and
by moving expensive checks further back.

Improve throws and doesNotThrow performance by removing dead
code and simplifying the overall logic.

PR-URL: nodejs#13973
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
  • Loading branch information
BridgeAR authored and refack committed Jul 9, 2017
1 parent 4d7946a commit be20e9e
Show file tree
Hide file tree
Showing 3 changed files with 189 additions and 193 deletions.
Loading

0 comments on commit be20e9e

Please sign in to comment.