Github Enterprise Compatibility

[markkevans]

I couldn't find a way to use this against a github enterprise instance as it always attempts to connect to github.com / api.github.com

This is possible according to the documentation at http://peter-murach.github.io/github/

github = Github.new do |config|
  config.endpoint    = 'https://github.company.com/api/v3'
  config.site        = 'https://github.company.com'
end

[codenamev]

@markkevans I've updated the gem with a few new setup switches that should allow you to configure GitReflow to use your Github Enterprise account. Please review the readme and let me know if it works for you as I have no way of testing this myself. I'll close once I get an 👌 from you.

[markkevans]

Great thanks! I'll test and confirm in the next couple of days

[nhance]

Hey @markkevans, any luck with this? I'd love to close this ticket out /cc @codenamev

[markkevans]

hi @nhance sorry for the delay.

I've tested this and the config part seems to work, I do get an error when using reflow review and reflow status which just says

error: undefined method `[]' for nil:NilClass

Is there a way I can debug where that is being thrown?

[codenamev]

@markkevans Can you try upgrading and see if this still happens? We fixed that issue in a recent release.

[zmbush]

I just ran into this problem as well.

The exception came from the following code:

def remote_user
  gh_remote_user = `git config --get remote.origin.url`.strip
  gh_remote_user.slice!(/github\.com[\/:](\w|-|\.)+/i)[11..-1]
end

Which i fixed by changing it to:

def remote_user
  gh_remote_user = `git config --get remote.origin.url`.strip
  gh_remote_user.slice!(/[\/:](\w|-|\.)+/i)[1..-1]
end

This function assumes that the remote url will be for github.com

[codenamev]

@zmbush we've made a pretty significant overhaul and have fixed those issues in 0.4.1