Skip to content

Commit

Permalink
Comments applied
Browse files Browse the repository at this point in the history
  • Loading branch information
gkonefal-reef committed Dec 3, 2017
1 parent 290b49c commit 21cbe79
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 19 deletions.
4 changes: 2 additions & 2 deletions doc/source/whatsnew/v0.22.0.txt
Original file line number Diff line number Diff line change
Expand Up @@ -245,5 +245,5 @@ Other
- Fixed a bug where creating a Series from an array that contains both tz-naive and tz-aware values will result in a Series whose dtype is tz-aware instead of object (:issue:`16406`)
- Fixed construction of a :class:`Series` from a ``dict`` containing ``NaN`` as key (:issue:`18480`)
- Adding a ``Period`` object to a ``datetime`` or ``Timestamp`` object will now correctly raise a ``TypeError`` (:issue:`17983`)
- BLD: since we already use setuptools, let's remove the optional logic in setup.py (:issue:`18113`)
-
- Simplified setup due to explicit dependence on setuptools (:issue:`18113`)
-
26 changes: 9 additions & 17 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,23 +41,17 @@ def is_platform_mac():
_CYTHON_INSTALLED = False


setuptools_kwargs = {}
min_numpy_ver = '1.9.0'
if sys.version_info[0] >= 3:
setuptools_kwargs = {
'install_requires': [
'python-dateutil >= 2' if sys.version_info[0] >= 3 else 'python-dateutil',
'pytz >= 2011k',
'numpy >= %s' % min_numpy_ver,
],
'setup_requires': ['numpy >= %s' % min_numpy_ver],
'zip_safe': False,
}

setuptools_kwargs = {'zip_safe': False,
'install_requires': ['python-dateutil >= 2',
'pytz >= 2011k',
'numpy >= %s' % min_numpy_ver],
'setup_requires': ['numpy >= %s' % min_numpy_ver]}
else:
setuptools_kwargs = {
'install_requires': ['python-dateutil',
'pytz >= 2011k',
'numpy >= %s' % min_numpy_ver],
'setup_requires': ['numpy >= %s' % min_numpy_ver],
'zip_safe': False,
}

from distutils.extension import Extension # noqa:E402
from distutils.command.build import build # noqa:E402
Expand Down Expand Up @@ -709,8 +703,6 @@ def pxd(name):
sources=['pandas/util/move.c'])
extensions.append(_move_ext)

setuptools_kwargs["test_suite"] = "nose.collector"

# The build cache system does string matching below this point.
# if you change something, be careful.

Expand Down

0 comments on commit 21cbe79

Please sign in to comment.