Feature/responsive single card chart component #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `CardLinearChart` component using the `nivo` library to render card data as a linear chart. - Added `ResponsiveSquare` component to maintain aspect ratio and responsiveness of the chart across various device sizes. - Integrated `usePageContext` for managing loading states during data fetch and rendering. - Enhanced `CardChart` container to dynamically calculate and update chart dimensions on window resize for improved UX. - Applied aspect ratio control in `CardChart` to ensure the chart stays within container boundaries without distortion. - Styled the components using MUI `styled` API with theme considerations for consistent UX. - Ensured error handling with `ErrorBoundary` for a safer, more reliable application experience. The above enhancements aim to provide a seamless and visually consistent charting experience across the app while ensuring data is represented accurately and responsively.
- Streamlined state management in AuthProvider by consolidating the use of `useState` and `useCookies` for a single source of truth. - Simplified state updates in `executeAuthAction` to reduce unnecessary re-renders. Considered the use of a reducer for grouped state management. - Enhanced Axios interceptor setup in `useEffect` for better handling of authorization headers, including cleanup logic to prevent memory leaks. - Optimized `resetLogoutTimer` and `logout` functions to reduce complexity and dependency recalculations. - Eliminated redundant `loginStatus` state, relying on individual states like `isLoggedIn`, `authUser`, etc. - Adjusted `useEffect` hooks to respond only to relevant changes in cookies, preventing unnecessary updates. - Updated `useEffect` dependency arrays to include only necessary dependencies and improve performance. - Removed the debugging `useEffect` in preparation for production deployment. These changes aim to enhance the performance, readability, and maintainability of the frontend authentication logic, ensuring a more efficient and reliable user authentication experience.
✅ Deploy Preview for tcg-store ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for enhanced-cardstore ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.