Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support conventional commits #31
Support conventional commits #31
Changes from 4 commits
b920b6b
0c4ebd1
0df8437
a449b75
352a996
73ade55
c6ea117
8180536
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting ... it only parses the last commit 🤔
This means the consumer of this action have to ensure to remember to have to correct keyword in the merge commit (if using merge commits)
I wonder how other tooling does this? e.g. https://semantic-release.gitbook.io/semantic-release
I wonder if this action should parse every commit between "this" commit, and the "current version" tag commit ?
--
I realised the above, because I wanted to rewrite this description to be:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... guess this isn't as straight forward 😅
Either this would imply that merge commits would have to follow the same convention to correctly increment the version.
Or like you said, parse every commit since the last version and work out what increment type the version to jump to. That sounds more 'right' to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Harder to do in bash though 😞