-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): Enable 'next' and 'experimental' tags for rw upgrade
#8024
Conversation
16 replays were recorded for e8227d4.
|
Reverted to simply add "next" and "experimental" to the allowed list of tags. I don't understand why we have an "experimental" tag given that we expect users to simply use the full SEMVER version for different experimental branches/features. |
Let's discuss this on the next core team meeting before we merge this PR please 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @Josh-Walker-GM I made some copy changes. Could you do a final check/confirmation and then merge?
Looping in @jtoar if we want to cherry-pick this into v4.5-RC
@Tobbe I'm asking to merge this before next meeting. Happy to discuss further. |
I checked again locally and things looked and worked fine. I'll enable auto-merge but this might get stuck on the flaky logger CI error for a little bit until that's resolved separately. |
…8024) * Add 'next' and 'experimental' tags for rw upgrade command * update cli help message * Allow experimental tags of the form 'experimental-*' * Revert to single experimental tag support * Update packages/cli/src/commands/upgrade.js * Update docs/docs/cli-commands.md * Update packages/cli/src/commands/upgrade.js --------- Co-authored-by: David Price <[email protected]>
…8024) * Add 'next' and 'experimental' tags for rw upgrade command * update cli help message * Allow experimental tags of the form 'experimental-*' * Revert to single experimental tag support * Update packages/cli/src/commands/upgrade.js * Update docs/docs/cli-commands.md * Update packages/cli/src/commands/upgrade.js --------- Co-authored-by: David Price <[email protected]>
Problem
We want to allow users to select the
next
andexperimental
tags when runningyarn rw upgrade --tag [tag]
but this is currently not allowed.Changes
next
andexperimental
to the allowed tags list.