Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Update node version for telemetry check #8004

Merged
merged 2 commits into from
Apr 4, 2023
Merged

chore(ci): Update node version for telemetry check #8004

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08a5816
Update ci.yml
Josh-Walker-GM Apr 3, 2023
e665451
Update ci.yml
Josh-Walker-GM Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
node-version: [16, 18]
node-version: [16.20.0, 18]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a miss on actions/setup-node's part. Not sure why 16 doesn't pull down the latest.

Just checked their docs—we could set the "check-latest" option to true:

Suggested change
node-version: [16.20.0, 18]
node-version: [16, 18]
check-latest: true

https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#check-latest-version

But maybe it's better to be more exact like you have it here since we support a minimum 16 version? I'll leave it up to you! If we go with 16.20.0 I'll have to change the settings to accept a check passing with that title, which is no big deal. Docs for reference:

redwood/packages/create-redwood-app/template/package.json

Line 17 in 385064d

"node": ">=16.20 <=18.x",

Copy link
Contributor

@jtoar jtoar Apr 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed the required check's name for now

fail-fast: true
name: 🔭 Telemetry check / ${{ matrix.os }} / node ${{ matrix.node-version }} latest
runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -360,7 +360,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
node-version: [16, 18]
node-version: [16.20.0, 18]
name: 🔭 Telemetry check / ${{ matrix.os }} / node ${{ matrix.node-version }} latest
runs-on: ${{ matrix.os }}
steps:
Expand Down