chore(deps): update dependency rimraf to v4 #7907

renovate · 2023-03-24T02:56:38Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
rimraf	`3.0.2` -> `4.4.1`

Release Notes

isaacs/rimraf

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

jtoar · 2023-03-24T04:09:50Z

We need to check all package build scripts; many of them use rimraf to get rid of test files.

replay-io · 2023-03-25T00:17:09Z

16 replays were recorded for 1f9a778.

0 Failed

16 Passed

requireAuth graphql checks

    ```
    locator.waitFor: Target closed
    =========================== logs ===========================
    waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
    ============================================================
    ```
  </ol>
</details>
<li><a href=https://app.replay.io/recording/85db418b-9f58-4d68-8b79-a3fd53e95bfa>useAuth hook, auth redirects checks</a></li>
<li><a href=https://app.replay.io/recording/ba492e27-5604-426a-91cb-1c7247bce8dd>Check that a specific blog post is prerendered</a></li>
<li><a href=https://app.replay.io/recording/6a03d283-3555-43f5-a2d1-b60456a8e879>Check that about is prerendered</a></li>
<li><a href=https://app.replay.io/recording/0531d986-40c2-47dd-b780-0217ba9c6a07>Check that homepage is prerendered</a></li>
<li><a href=https://app.replay.io/recording/9a7c6a3e-c163-4ce0-b4b7-858acb1779cf>Check that meta-tags are rendering the correct dynamic data</a></li>
<li><a href=https://app.replay.io/recording/f1219194-9ee1-493b-8dda-0d5e7ca18645>Check that you can navigate from home page to specific blog post</a></li>
<li><a href=https://app.replay.io/recording/6551ebdb-66f9-45ba-951e-2c6b134b10f3>Waterfall prerendering (nested cells)</a></li>
<li><a href=https://app.replay.io/recording/2782ae6b-c7a8-48a4-8a27-f6679b7febe2>RBAC: Admin user should be able to delete contacts</a></li>
<li><a href=https://app.replay.io/recording/42fb578f-6287-40c2-8fd5-3dc0341d5be0>RBAC: Should not be able to delete contact as non-admin user</a></li>
<li><a href=https://app.replay.io/recording/5dba1c30-615f-4e8b-8aa0-61e00fde3ec3>Smoke test with dev server</a></li>
<li><a href=https://app.replay.io/recording/334716b5-1cfa-40b0-8807-ab322a6d8057>Smoke test with rw serve</a></li>
<li><a href=https://app.replay.io/recording/468e1de6-1e60-4805-b7dc-0e4492858210>Loads Cell mocks when Cell is nested in another story</a></li>
<li><a href=https://app.replay.io/recording/30f8c289-14c2-4401-9ad2-703520db007c>Loads Cell Stories</a></li>
<li><a href=https://app.replay.io/recording/8e3b7eb2-b2a1-4342-a3a0-4ad511470543>Loads MDX Stories</a></li>
<li><a href=https://app.replay.io/recording/749706ba-e826-445e-9b94-3faebbf01776>Mocks current user, and updates UI while dev server is running</a></li>

View test run on Replay ↗︎

…dwood into renovate/rimraf-4.x

thedavidprice · 2023-03-25T01:51:44Z

@types/rimraf dep no longer necessary https://www.npmjs.com/package/@types/rimraf
Breaking: "The function returns a Promise instead of taking a callback" from https://github.com/isaacs/rimraf
re: rimraf.sync() "...the synchronous form will typically be significantly slower than the async form"
CLI now requires --glob when applicable

Testing locally, including test-project and project yarn rw build.

Subjectively await rimraf() might be a bit faster than rimraf.sync()

thedavidprice · 2023-03-25T01:53:13Z

package.json

@@ -7,7 +7,7 @@
  ],
  "scripts": {
    "build": "lerna run build",
-    "build:clean": "yarn clean:prisma && rimraf \"packages/**/dist\"",
+    "build:clean": "yarn clean:prisma && rimraf \"packages/**/dist\" --glob",


new config required. Note: I tested locally to confirm working, especially in case of test directories

renovate · 2023-03-25T01:53:41Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

thedavidprice · 2023-03-25T01:53:47Z

packages/cli/src/commands/buildHandler.js

@@ -89,7 +89,7 @@ export const handler = async ({
      // Vite handles this internally
      title: 'Cleaning Web...',
      task: () => {
-        rimraf.sync(rwjsPaths.web.dist)
+        rimraf(rwjsPaths.web.dist)


rimraf() now returns promise. rimraf.sync() is slower

thedavidprice · 2023-03-25T01:54:09Z

tasks/framework-tools/lib/project.mjs

@@ -117,7 +117,7 @@ export async function copyFrameworkFilesToProject(
      files.length,
      'files'
    )
-    rimraf.sync(packageDstPath)
+    await rimraf(packageDstPath)


using new return Promise behavior

thedavidprice · 2023-03-25T01:55:20Z

yarn.lock

@@ -9658,7 +9656,7 @@ __metadata:
  languageName: node
  linkType: hard

-"@types/rimraf@npm:3.0.2, @types/rimraf@npm:^3.0.2":
+"@types/rimraf@npm:^3.0.2":


hmm, this shouldn't be here anymore as types are included in v4 Checking

It's ok. Required by the google-gax dep

packages/cli/src/commands/buildHandler.js

* chore(deps): update dependency rimraf to v4 * chore(deps): update dependency rimraf to v4 * codemod breaking changes * Update packages/cli/src/commands/buildHandler.js --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: David Price <[email protected]> Co-authored-by: Dominic Saadi <[email protected]>

* 'main' of github.com:redwoodjs/redwood: (162 commits) fix(deps): update dependency @escape.tech/graphql-armor to v1.8.0 (redwoodjs#7922) chore(deps): update dependency @playwright/test to v1.32.1 (redwoodjs#7924) chore(deps): update dependency @testing-library/dom to v9.2.0 (redwoodjs#7921) chore(deps): update dependency rimraf to v4 (redwoodjs#7907) fix(deps): update dependency react-hook-form to v7.43.8 (redwoodjs#7920) fix(deps): update dependency @fastify/http-proxy to v9 (redwoodjs#7889) fix(deps): update dependency @types/node to v16.18.20 (redwoodjs#7919) chore(deps): update dependency @replayio/playwright to v0.3.27 (redwoodjs#7918) fix(Clerk): call reauthenticate before navigating (redwoodjs#7917) chore(deps): update dependency esbuild to v0.17.13 (redwoodjs#7915) chore(deps): update dependency lerna to v6.6.1 (redwoodjs#7916) chore(deps): update dependency @tsd/typescript to v5 (redwoodjs#7856) chore(deps): update dependency @testing-library/dom to v9.1.0 (redwoodjs#7914) fix(deps): update dependency msw to v1.2.1 (redwoodjs#7911) chore(deps): update dependency @types/react to v18.0.29 (redwoodjs#7912) chore(deps): update dependency nx to v15.8.9 (redwoodjs#7913) Fix for directUrl usage during testing (redwoodjs#7898) fix(deps): update dependency prettier to v2.8.7 (redwoodjs#7908) chore(deps): update dependency @nrwl/nx-cloud to v15.3.2 (redwoodjs#7904) fix(deps): update dependency @types/node to v16.18.19 (redwoodjs#7906) ...

renovate bot added the release:chore This PR is a chore (means nothing for users) label Mar 24, 2023

renovate bot assigned jtoar Mar 24, 2023

renovate bot force-pushed the renovate/rimraf-4.x branch 11 times, most recently from 951ad38 to 7f4e96b Compare March 24, 2023 23:34

chore(deps): update dependency rimraf to v4

7e1640b

renovate bot force-pushed the renovate/rimraf-4.x branch from 7f4e96b to 7e1640b Compare March 25, 2023 00:06

chore(deps): update dependency rimraf to v4

68c650a

renovate bot force-pushed the renovate/rimraf-4.x branch from 7e1640b to 68c650a Compare March 25, 2023 00:44

thedavidprice added 2 commits March 24, 2023 18:48

Merge branch 'renovate/rimraf-4.x' of https://github.com/redwoodjs/re…

cebeaa9

…dwood into renovate/rimraf-4.x

codemod breaking changes

c6f47e2

Merge branch 'main' into renovate/rimraf-4.x

ffe29ec

thedavidprice requested a review from jtoar March 25, 2023 01:52

thedavidprice reviewed Mar 25, 2023

View reviewed changes

jtoar reviewed Mar 25, 2023

View reviewed changes

packages/cli/src/commands/buildHandler.js Outdated Show resolved Hide resolved

Update packages/cli/src/commands/buildHandler.js

bebe470

jtoar approved these changes Mar 25, 2023

View reviewed changes

Merge branch 'main' into renovate/rimraf-4.x

1f9a778

thedavidprice enabled auto-merge (squash) March 25, 2023 03:20

thedavidprice merged commit e1098c4 into main Mar 25, 2023

thedavidprice deleted the renovate/rimraf-4.x branch March 25, 2023 03:52

redwoodjs-bot bot added this to the next-release milestone Mar 25, 2023

jtoar modified the milestones: next-release, v5.0.0 Mar 27, 2023

jtoar modified the milestones: next-release, v4.5.0 Apr 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update dependency rimraf to v4 #7907

chore(deps): update dependency rimraf to v4 #7907

renovate bot commented Mar 24, 2023

jtoar commented Mar 24, 2023

replay-io bot commented Mar 25, 2023 •

edited

Loading

thedavidprice commented Mar 25, 2023

thedavidprice Mar 25, 2023

renovate bot commented Mar 25, 2023

thedavidprice Mar 25, 2023

thedavidprice Mar 25, 2023

thedavidprice Mar 25, 2023

thedavidprice Mar 25, 2023

chore(deps): update dependency rimraf to v4 #7907

chore(deps): update dependency rimraf to v4 #7907

Conversation

renovate bot commented Mar 24, 2023

Release Notes

Configuration

jtoar commented Mar 24, 2023

replay-io bot commented Mar 25, 2023 • edited Loading

thedavidprice commented Mar 25, 2023

Choose a reason for hiding this comment

renovate bot commented Mar 25, 2023

Edited/Blocked Notification

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

replay-io bot commented Mar 25, 2023 •

edited

Loading