Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test TS errors #7860

Merged
merged 2 commits into from
Mar 18, 2023
Merged

Fix unit test TS errors #7860

merged 2 commits into from
Mar 18, 2023

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Mar 18, 2023

Fixes a few unit test TS errors

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Mar 18, 2023
@Tobbe Tobbe enabled auto-merge (squash) March 18, 2023 14:38
@replay-io
Copy link

replay-io bot commented Mar 18, 2023

16 replays were recorded for 64457d3.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/1fa2bf72-4cb0-4a4a-a61f-3c1158b10a5f>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/cc265c3a-1ed9-44cb-bbdd-3bc479dd37ca>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/6080370b-2899-407d-bfe6-16d327634be7>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/342e9257-612f-4478-a87a-c03c1a720826>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/f28a7878-cf6e-495b-9ad8-a6ff739bc938>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/88e80f5b-2b55-4c99-9a72-5dbf09700403>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/36952547-59a2-4b8f-8a4e-7f6d6d5e07ba>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/1b9c68a5-77cc-486d-8f5f-3d3798f21d10>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/e18e11bb-e073-4e0b-afac-775f8facf829>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/7ff96bb6-156d-4bb3-970c-466239d54b24>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/d31b2c6b-4b1d-4933-ad6f-95cc9e1f4f55>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/ce2bd31b-2f13-4caa-abb2-bb6633cbdc02>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/6667fff7-686d-4b71-8f49-e0654fbe5cab>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/ba1c4f58-3ef0-4da7-830c-03b4504ef82d>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/c60a37e4-068b-4a26-ae67-45c6f172f738>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@Tobbe Tobbe merged commit 1dfb0ba into redwoodjs:main Mar 18, 2023
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Mar 18, 2023
@Tobbe Tobbe deleted the tobbe-jest-ts-fixes branch March 18, 2023 15:22
jtoar pushed a commit that referenced this pull request Mar 23, 2023
@thedavidprice thedavidprice modified the milestones: next-release, v4.4.0 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants