-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
babel-plugin-redwood-routes-auto-loader.tests.ts: Break up into separate tests #7858
Merged
Tobbe
merged 1 commit into
redwoodjs:main
from
Tobbe:tobbe-babel-plugin-redwood-routes-auto-loader-test-describe
Mar 18, 2023
Merged
babel-plugin-redwood-routes-auto-loader.tests.ts: Break up into separate tests #7858
Tobbe
merged 1 commit into
redwoodjs:main
from
Tobbe:tobbe-babel-plugin-redwood-routes-auto-loader-test-describe
Mar 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
commented
Mar 18, 2023
|
||
beforeAll(() => { | ||
process.env.RWJS_CWD = FIXTURE_PATH | ||
result = transform(getPaths().web.routes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtoar This was key. We left it outside beforeAll
, so it tried to run getPaths()
before RWJS_CWD
was defined
16 replays were recorded for 428bb48.
|
jtoar
pushed a commit
that referenced
this pull request
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor tests
Wrap tests in a
describe
, and break the one test with multiple assertions up into separate tests.