Fix: The configureFastify codemod now handles missing config case #6383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dac09 reported that if one was upgraded an older version of Redwood proper to api-server's introduction of the Fastify config (server.config.js), the v3 codemode to configure-fastify would fail ungracefully.
The PR updates to coded to check
server.config.jsexist? If so, then transform and upgrade it.server.config.jsand save it to the project's api directory.I tested by removing my
server.config.jsfrom a project (that is inpath/to/my/rw/projectand then ranAnd a new server.config.js now exists in my project.