Better private Set error handling and test coverage #6359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
approved these changes
Sep 10, 2022
jtoar
approved these changes
Sep 10, 2022
jtoar
pushed a commit
that referenced
this pull request
Sep 13, 2022
* Better private Set error handling and test coverage * Move unauthenticated undefined check to help TS understand the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Routes file when using the Private set with an "unauthenticated" route that requires a parameter, the error message shown is a bit misleading. It says "We could not find a route named bazinga".
This PR reworks the error handling a little bit to show better error messages depending on what goes wrong. It also adds test for this.