Fix getCurrentUser type to get rid of red squiggles #6329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
changed the title
dac09
reviewed
Sep 1, 2022
dac09
reviewed
Sep 1, 2022
dac09
reviewed
Sep 2, 2022
packages/cli/src/commands/setup/auth/templates/azureActiveDirectory.auth.ts.template
Show resolved
Hide resolved
dac09
reviewed
Sep 2, 2022
packages/cli/src/commands/setup/auth/templates/auth0.auth.ts.template
Outdated
Show resolved
Hide resolved
jtoar
pushed a commit
that referenced
this pull request
Sep 3, 2022
Co-authored-by: Daniel Choudhury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6328
(This PR is continued/fixed over here: #6340)
Here's the red squiggly we see inside
createGraphQLHandlerNow let's take a look at when/how
getCurrentUseris called inside the FW. Again, as seen in the first screenshot it's passed intocreateGraphQLHandlerSo we need to align all three different types used for the same thing here.
The solution isn't perfect. But it's better than it was. No more red squiggles, and not a bunch of new
anys. I think this is good enough as a stop gap solution until we've fully decoupled auth and we more naturally get different types depending on what provider you're using.