Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup exclude: Eagerly match all 'setup' in path #6168

Merged
merged 4 commits into from
Aug 8, 2022

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Aug 8, 2022

Fixes #6167

Updated the regex to be smarter about how it matches the path

@Tobbe Tobbe added the release:fix This PR is a fix label Aug 8, 2022
@nx-cloud
Copy link

nx-cloud bot commented Aug 8, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 08a66e3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 14 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Aug 8, 2022

Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit 08a66e3
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62f139aa426f8e00088247b6

@Tobbe Tobbe added the fixture-ok Override the test project fixture check label Aug 8, 2022
@Tobbe Tobbe requested a review from dac09 August 8, 2022 16:23
Copy link
Contributor

@dac09 dac09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have another one of these in the setup ui command. Ok to change that also?

Copy link
Member Author

Tobbe commented Aug 8, 2022

Dom mentioned that one, but it's actually not there anymore. But I'll double check if there are more

Copy link
Member Author

Tobbe commented Aug 8, 2022

generate had one too. Fixed that one as well

@Tobbe Tobbe enabled auto-merge (squash) August 8, 2022 16:28
@dac09
Copy link
Contributor

dac09 commented Aug 8, 2022

Lets also wait to see the output of the rw setup ui --help and setup ui auth commands in the windows build steps. Looks ok to me, but worth checking

@Tobbe Tobbe merged commit 8e116c3 into redwoodjs:main Aug 8, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Aug 8, 2022
@Tobbe
Copy link
Member Author

Tobbe commented Aug 8, 2022

@jtoar Tagging you incase you wanted to see the solution I came up with

@jtoar
Copy link
Contributor

jtoar commented Aug 9, 2022

@Tobbe nice! I think I understand what you did but not the syntax still haha.

@jtoar jtoar modified the milestones: next-release, v3.0.0 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:fix This PR is a fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug?]: RW's setup auth command fails in project named "xyzsetup"
3 participants