Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ts): Update some TS links, and add a tip to the tutorial #6095

Merged
merged 2 commits into from
Aug 1, 2022
Merged

docs(ts): Update some TS links, and add a tip to the tutorial #6095

merged 2 commits into from
Aug 1, 2022

Conversation

dac09
Copy link
Contributor

@dac09 dac09 commented Aug 1, 2022 •
edited
Loading

  1. Updates the links for generated and utlity types.
  2. Adds a tip in the tutorial where we'd get a TypeScript error (see here Fix type error in TS article ID #5878)

@nx-cloud
Copy link

nx-cloud bot commented Aug 1, 2022 •
edited
Loading

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit ebc5e51.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Aug 1, 2022 •
edited
Loading

✅ Deploy Preview for redwoodjs-docs ready!

Name Link
🔨 Latest commit ebc5e51
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62e7f67dcc1fe40008546ef5
😎 Deploy Preview https://deploy-preview-6095--redwoodjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dac09 dac09 mentioned this pull request Aug 1, 2022
Closed
dthyresson
dthyresson approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@dthyresson dthyresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I actually fixed some of those broken typescript gen links in my docs update for GraphQL Self-Docs. I'll remove them and update from this PR.

@dac09 dac09 added the release:docs This PR only updates docs label Aug 1, 2022
@dac09 dac09 merged commit d7bced6 into redwoodjs:main Aug 1, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Aug 1, 2022
@dac09 dac09 deleted the docs/ts-links-and-tips branch August 1, 2022 16:08
@jtoar jtoar modified the milestones: next-release, v3.0.0 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dthyresson dthyresson dthyresson approved these changes

@cannikin cannikin Awaiting requested review from cannikin

Assignees

@dac09 dac09

Labels
release:docs This PR only updates docs
Projects
Main
Status: Archived
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dac09 @dthyresson @jtoar