Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial 6.2: Wrap JSX element array in fragment tag #6043

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Jul 25, 2022

Although only existing for a short period during the tutorial, these should be wrapped (just like in the version on the JS tab), otherwise a red squiggle appears in the Success-story reading:

'Success' cannot be used as a JSX component.
  Its return type 'Element[]' is not a valid JSX element.
    Type 'Element[]' is missing the following properties from type 'Element': type, props, keyts(2786)

Also, with this addition, the changed lines highlighting in the next step becomes harmonizes again (otherwise the whole return section would need to be highlighted).

@nx-cloud
Copy link

nx-cloud bot commented Jul 25, 2022

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit d22c3d3.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Jul 25, 2022

Deploy Preview for redwoodjs-docs ready!

Name Link
🔨 Latest commit d22c3d3
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62df770a4aa12800088d8197
😎 Deploy Preview https://deploy-preview-6043--redwoodjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Philzen Philzen changed the title Wrap JSX element array in fragment tag Tutorial 6.2: Wrap JSX element array in fragment tag Jul 25, 2022
@jtoar jtoar assigned jtoar and unassigned noire-munich Jul 26, 2022
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Philzen!

@jtoar jtoar added the release:docs This PR only updates docs label Jul 26, 2022
@jtoar jtoar enabled auto-merge (squash) July 26, 2022 05:04
@jtoar jtoar merged commit 981d063 into redwoodjs:main Jul 26, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jul 26, 2022
@jtoar jtoar modified the milestones: next-release, v3.0.0 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:docs This PR only updates docs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants