-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Updates envelop types to v.2.3.0 #6038
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f7647d9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 14 targets
Sent with 💌 from NxCloud. |
✅ Deploy Preview for redwoodjs-docs canceled.
|
@dthyresson did the code changes I made look ok to you? I didn't feel super confident in them so wanted to make sure I didn't break anything. |
bdf48b2
to
9f21841
Compare
Yes, but I also had to update the tests for specific types. Tests are passing and no type warnings, but want to give @dac09 a chance to review was well. |
Hey gents, I had a look through this - the specific changes here look OK to me but I wonder if we're doing something wrong with the plugin types in the first place? I'm confused as to why we need to typecast... it also seems to me that I don't want to hold this PR - but we may be hiding some bigger problems here... |
We actually are using I am renaming to avoid the confusion with the envelop lifecycle event |
@dac09 See above comment about renaming the function to avoid confusion with If good, then I'll merge. |
Haha I'm still confused DT - but if you're confident, feel free to merge! I've been out of touch of this for a while - so maybe you can just explain this to me at a later time! |
Am closing out the Renovate PR #5018 in favor of this due to conflicts.
This PR: