Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds flags to skip prompting of WebAuthn install for headless commands #6022

Merged
merged 14 commits into from
Jul 26, 2022

Conversation

cannikin
Copy link
Member

@cannikin cannikin commented Jul 22, 2022

When generating a test project with yarn build:test-project the setup and generate commands for dbAuth were getting stuck because there is an interactive prompt asking the user if they want to install WebAuthn support. This PR adds a flag --webauthn and --no-webauthn to skip the prompt.

This PR also makes the base64url import a devDependency in the api package and then adds it as a regular dependency if/when you setup dbAuth, adding it to the app's package.json.

NOTE At this time there's still a weird dependency error where it appears the CLI is somehow importing something that imports base64url. Building the test project I see this error when it gets to the yarn rw g secret step: @dac09 and @jtoar believe this was fixed by rebuilding the test project fixture.

@cannikin cannikin added topic/auth release:feature This PR introduces a new feature labels Jul 22, 2022
@cannikin cannikin self-assigned this Jul 22, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jul 22, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cf44b76. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 14 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Jul 22, 2022

Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit cf44b76
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62e01717b7d4b80009bb0984

@cannikin cannikin requested a review from dac09 July 22, 2022 17:47
@cannikin cannikin enabled auto-merge (squash) July 25, 2022 18:47
@cannikin cannikin disabled auto-merge July 26, 2022 16:32
@cannikin cannikin merged commit b15be7f into main Jul 26, 2022
@cannikin cannikin deleted the rc-webauthn-deps branch July 26, 2022 16:32
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jul 26, 2022
@jtoar jtoar removed this from the next-release milestone Sep 2, 2022
@jtoar jtoar added this to the v3.0.0 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature This PR introduces a new feature topic/auth
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants