-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds flags to skip prompting of WebAuthn install for headless commands #6022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when setting up dbAuth
… when generating login pages
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cf44b76. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 14 targets
Sent with 💌 from NxCloud. |
✅ Deploy Preview for redwoodjs-docs canceled.
|
dac09
reviewed
Jul 22, 2022
dac09
reviewed
Jul 22, 2022
dac09
reviewed
Jul 22, 2022
packages/cli/src/commands/setup/auth/providers/dbAuth.webAuthn.js
Outdated
Show resolved
Hide resolved
dac09
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a test project with
yarn build:test-project
the setup and generate commands for dbAuth were getting stuck because there is an interactive prompt asking the user if they want to install WebAuthn support. This PR adds a flag--webauthn
and--no-webauthn
to skip the prompt.This PR also makes the
base64url
import a devDependency in theapi
package and then adds it as a regular dependency if/when you setup dbAuth, adding it to the app'spackage.json
.NOTE At this time there's still a weird dependency error where it appears the CLI is somehow importing something that imports@dac09 and @jtoar believe this was fixed by rebuilding the test project fixture.base64url
. Building the test project I see this error when it gets to theyarn rw g secret
step: