feat(internal): generate proper types for cells with custom props

[codekrafter]

Ref discord conversation at https://discord.com/channels/679514959968993311/998984413167767623

This modifies cell type generation to try to find a beforeQuery statement. If it finds one, it uses the first parameter's type as the Props type, instead of the GraphQL query variables.

[netlify]

✅ Deploy Preview for redwoodjs-docs ready!

Name	Link
🔨 Latest commit	44f5bc5
🔍 Latest deploy log	https://app.netlify.com/sites/redwoodjs-docs/deploys/62df77f06031080009c71f7f
😎 Deploy Preview	https://deploy-preview-6014--redwoodjs-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 44f5bc5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 14 targets

• cli run test --concurrency 2 -- --colors --maxWorkers 2
• cli run test --concurrency 2 -- --colors --maxWorkers 2
• cli run test --concurrency 2 -- --colors --maxWorkers 2
• cli run build
• cli run test --concurrency 2 -- --colors --maxWorkers 2
• cli run build
• cli run build
• cli run build
• cli run build
• cli run build
• cli run build
• cli run build
• cli run build
• cli run build

---

Sent with 💌 from NxCloud.

[peterp]

Very cool!

[noire-munich]

thanks a lot for this @codekrafter , that's a cool addition to cells 👍🏻 .

@dthyresson I'm too fresh at typescript to be confident in my review, I'd approve it but would appreciate a second opinion.

(Edit: posted my approval as I took the opportunity to learn about what puzzled me at first sight ).

[dthyresson]

@dac09 and @Tobbe I was assigned to review this PR, but I'm not sure I follow and this is deep into Cell types. Should we discuss?

[dthyresson]

Thanks @codekrafter for this!

I think we'll need some test of this behavior. Maybe in the test project to make a cell query for e2e? Or better yet in createCell.test?

[dthyresson]

@codekrafter Please see prior comment. Could you add a test in createCell.test to verify this behavior, thanks!

[dthyresson]

@codekrafter after leaving the comment, @Tobbe let me know that it is hard to test a TS change. If that's the case, let me know and perhaps instead we add documentation to showcase the behavior and options in the cell docs?

[codekrafter]

@dthyresson

It is a little hard to test just types, but exploring that testing file I was able to add a general beforeQuery test (which was missing before). There was also a small typing issues with the actual createCell implementation that popped up while adding that test I added a fix for.

I also added some content to the beforeQuery section of the Cell documentation to cover this behavior

[dthyresson]

@dthyresson

It is a little hard to test just types, but exploring that testing file I was able to add a general beforeQuery test (which was missing before). There was also a small typing issues with the actual createCell implementation that popped up while adding that test I added a fix for.

Thanks -- I now understand much better.

I also added some content to the beforeQuery section of the Cell documentation to cover this behavior

Amazing, Thanks so much for this!

Testing behavior isn't possible since this is a TS change, but docs were added to explain instead.

[dthyresson]

@Tobbe LGTM but since you alerted me to the TS change and testing issue, would be great to get your take on the documentation update to explain use.

[codekrafter]

Just noticed I had a small typo in the docs for one of my examples, should be fixed now.