Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name option on yarn rw prisma #5147

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Fix name option on yarn rw prisma #5147

merged 2 commits into from
Apr 13, 2022

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Apr 13, 2022

Closes #5135. If you pass multiple words to yarn rw prisma migrate dev --name (or -n), like this:

yarn rw prisma migrate dev -n "create user"

The quotes around "create user" don't make it to prisma. So the command ends up looking like:

$ yarn prisma migrate dev -n create user --schema "/Users/dom/prjcts/prisma-name/prisma-name/api/db/schema.prisma"

The value of -n is create, not create user. This interferes with the --schema option that follows. This PR makes sure there's quotes if the value of an option is more than one word.

@jtoar jtoar added topic/cli release:fix This PR is a fix labels Apr 13, 2022
@netlify
Copy link

netlify bot commented Apr 13, 2022

Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit f37a5c2
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/625746b43016000008831089

@jtoar jtoar self-assigned this Apr 13, 2022
@Tobbe Tobbe enabled auto-merge (squash) April 13, 2022 21:55
@Tobbe Tobbe merged commit b667f8d into main Apr 13, 2022
@Tobbe Tobbe deleted the ds-fix-name-prisma-option branch April 13, 2022 22:17
@jtoar jtoar added this to the next-release milestone Apr 13, 2022
@thedavidprice thedavidprice modified the milestones: next-release, v1.1.0 Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix topic/cli
Projects
No open projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

yarn rw prisma migrate dev -n "create user" not working
4 participants