Ignore Storybook CSS alias if file doesn't exist #5144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redwoodjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jtoar
force-pushed
the
ds-fix-storybook-css-alias
branch
from
25b8f36 to
8757313
Compare
|
Yeah Not sure its worth it in the smoke test, as long as you've tested the different permutations, should be fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5143.
Many users don't use the
web/src/index.cssfile. If they remove it, it breaks storybook since storybook tries to require it. This PR makes the webpack alias default to false so that webpack doesn't break hard if it's not there. See https://webpack.js.org/configuration/resolve/#resolvealias.@dac09 one way of testing this is to add two steps to the smoke test workflow. The first one would remove the index.css file and the second would run the storybook smoke test again. Should I go ahead and make those changes to this PR, or does it seem like more overhead than it's worth?