Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baremetal deploy #5139

Merged
merged 21 commits into from
Apr 14, 2022
Merged

Baremetal deploy #5139

merged 21 commits into from
Apr 14, 2022

Conversation

zpeters
Copy link
Contributor

@zpeters zpeters commented Apr 13, 2022 •
edited by thedavidprice
Loading

No description provided.

@netlify
Copy link

netlify bot commented Apr 13, 2022 •
edited
Loading

✅ Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit 4b19a30
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/625764bd012bac0009581a2e

@zpeters zpeters mentioned this pull request Apr 13, 2022
Closed
@jtoar jtoar requested a review from cannikin April 13, 2022 14:40
cannikin
cannikin requested changes Apr 13, 2022
View reviewed changes
Copy link
Member

@cannikin cannikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks again for doing this! :) Have you tried using this locally, does everything work as expected?

My comments are mostly minor text changes.

docs/docs/deploy/baremetal.md Outdated Show resolved Hide resolved
docs/docs/deploy/baremetal.md Outdated Show resolved Hide resolved
docs/docs/deploy/baremetal.md Outdated Show resolved Hide resolved
docs/docs/deploy/baremetal.md Outdated Show resolved Hide resolved
docs/docs/deploy/baremetal.md Outdated Show resolved Hide resolved
docs/docs/deploy/baremetal.md Show resolved Hide resolved
docs/docs/deploy/baremetal.md Show resolved Hide resolved
docs/docs/deploy/baremetal.md Outdated Show resolved Hide resolved
docs/docs/deploy/baremetal.md Outdated Show resolved Hide resolved
docs/docs/deploy/baremetal.md Show resolved Hide resolved
@cannikin
Copy link
Member

There may have been some doubled-up comments there, sorry about that... I've got a weird issue lately where everything to GitHub is double-submitted for some reason. It'll probably happen to this comment, watch...

@cannikin
Copy link
Member

cannikin commented Apr 13, 2022 •
edited
Loading

There may have been some doubled-up comments there, sorry about that... I've got a weird issue lately where everything to GitHub is double-submitted for some reason. It'll probably happen to this comment, watch...

SEE???

zpeters and others added 9 commits April 13, 2022 18:19
@zpeters @cannikin
Update docs/docs/deploy/baremetal.md
7353182 
Co-authored-by: Rob Cameron <[email protected]>
@zpeters @cannikin
Update docs/docs/deploy/baremetal.md
3da9b91 
Co-authored-by: Rob Cameron <[email protected]>
@zpeters @cannikin
Update docs/docs/deploy/baremetal.md
6d5a97c 
Co-authored-by: Rob Cameron <[email protected]>
@zpeters @cannikin
Update docs/docs/deploy/baremetal.md
3541a0b 
Co-authored-by: Rob Cameron <[email protected]>
@zpeters @cannikin
Update docs/docs/deploy/baremetal.md
bf779db 
Co-authored-by: Rob Cameron <[email protected]>
@zpeters @cannikin
Update docs/docs/deploy/baremetal.md
0077a58 
Co-authored-by: Rob Cameron <[email protected]>
@zpeters @cannikin
Update docs/docs/deploy/baremetal.md
839b012 
Co-authored-by: Rob Cameron <[email protected]>
@zpeters @cannikin
Update docs/docs/deploy/baremetal.md
a8b57c5 
Co-authored-by: Rob Cameron <[email protected]>
@zpeters @cannikin
Update docs/docs/deploy/baremetal.md
0c6b08c 
Co-authored-by: Rob Cameron <[email protected]>
@zpeters
Copy link
Contributor Author

zpeters commented Apr 13, 2022

There may have been some doubled-up comments there, sorry about that... I've got a weird issue lately where everything to GitHub is double-submitted for some reason. It'll probably happen to this comment, watch...

SEE???

No worries, i figured you were just really excited for this feature!

To sum up i have run this locally on an existing project multiple times, simulating a "first run" and subsequent runs. Everything worked as expected. I am happy to do whatever depth of testing you'd like so i can fit the standards you have for the project.

Thank you for the grammar and wording corrections above. I figured we'd need to go back and forth a bit to get the style consistent.

I will commit/wrap up the comments you left and hopefully have this on it's way

zpeters
zpeters commented Apr 13, 2022
View reviewed changes
Copy link
Contributor Author

@zpeters zpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe i have everything addresses. If i missed something please let me know. I'm not super familiar with github

docs/docs/deploy/baremetal.md Outdated Show resolved Hide resolved
docs/docs/deploy/baremetal.md Outdated Show resolved Hide resolved
@cannikin cannikin merged commit 88c296e into redwoodjs:main Apr 14, 2022
@jtoar jtoar added this to the next-release milestone Apr 14, 2022
@cannikin
Copy link
Member

Great work on this one, thanks!

@zpeters zpeters deleted the baremetal-deploy branch April 14, 2022 11:56
@thedavidprice thedavidprice modified the milestones: next-release, v1.1.0 Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cannikin cannikin cannikin approved these changes

Assignees
No one assigned
Labels
release:fix This PR is a fix topic/deployment topic/docs
Projects
No open projects
Release
Status: Archived
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zpeters @cannikin @thedavidprice @jtoar