Enable vscode debugging on api server #4904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redwoodjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@cannikin - I've actually reviewed the code here its good to go, this PR I'm adding just adds extra tests and the docs. Would you mind reviewing the docs please? Uses MDX, so didn't want to merge without another pair of eyes! |
orta
reviewed
Mar 24, 2022
|
Thanks Daniel |
cannikin
requested changes
Mar 25, 2022
Co-authored-by: Rob Cameron <[email protected]>
Co-authored-by: Rob Cameron <[email protected]>
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Mar 29, 2022
…tory-routing * 'main' of github.com:redwoodjs/redwood: chore(deps): update dependency cypress to v9.5.3 (redwoodjs#4955) chore(deps): update dependency @supabase/supabase-js to v1.33.1 (redwoodjs#4951) chore(deps): update dependency @clerk/types to v2 (redwoodjs#4920) fix flightcontrol template and doc (redwoodjs#4934) Fix test-project linting errors (redwoodjs#4942) More clerk doc comment updates (redwoodjs#4943) fix(deps): update dependency eslint to v8.12.0 (redwoodjs#4938) chore(deps): update dependency esbuild to v0.14.28 (redwoodjs#4936) Enable vscode debugging on api server (redwoodjs#4904)
thedavidprice
pushed a commit
that referenced
this pull request
Mar 31, 2022
* Enable debugging api server as forked by "yarn rw dev" on configured port (#4694) * Add test for api debug port * Update launch.json to with api debug * Set debug port to 18911 by default * Add docs for api deubgging * Pin react-player, cleanup doc * Update snapshot and launch.json in fixture * Add more info in docs | Fix ynar * Update docs/docs/project-configuration-dev-test-build.mdx Co-authored-by: Rob Cameron <[email protected]> * Update docs/docs/project-configuration-dev-test-build.mdx Co-authored-by: Rob Cameron <[email protected]> Co-authored-by: twodotsmax <[email protected]> Co-authored-by: Rob Cameron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR from @twodotsmax
Additional tasks for Danny
Regenerate the test fixture so it uses the latest template :)Manually added the launch.json, because
--rebuild-fixtureseems to be broken currently