Consider not running CI on changes to docs (continued) #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redwoodjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jtoar
force-pushed
the
ds-fix-skipping-ci-for-docs
branch
from
eca783e to
8ea128a
Compare
Merged
|
Closing in favor of #5207. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4816.
There's unfortunately not a great way to to do this. See this discussion: community/community#13690.
I've looked at a few other repos for inspiration, but it doesn't seem like they use protected branches, so they can merge changes to docs without having to "pass" required checks.
Only Next.js does something similar to this (see https://github.com/vercel/next.js/blob/canary/.github/workflows/build_test_deploy.yml; almost every step has
if: ${{needs.build.outputs.docsChange != 'docs only change'}}); it's tedious, but I'm not sure that there's a better way yet.