Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jobs): merge job options to prevent 'undefined' values in place of defaults #11666

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix(jobs): merge job options to prevent 'undefined' values in place of defaults #11666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/jobs/src/core/Worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,18 @@ export class Worker {
lastCheckTime: Date

constructor(options: WorkerOptions) {
this.options = { ...DEFAULT_OPTIONS, ...options }
// Note: if we did a simple spread like { ...DEFAULT_OPTIONS, ...options } then any undefined values in `options`
// would override the defaults. We want to keep the defaults if the value is `undefined` so we have to do this
const nonUndefinedOptions = Object.fromEntries(
Object.entries(options ?? {}).filter(([_, value]) => value !== undefined),
)
this.options = {
...DEFAULT_OPTIONS,
...nonUndefinedOptions,
adapter: options?.adapter,
processName: options?.processName,
queues: options?.queues,
}

if (!options?.adapter) {
throw new AdapterRequiredError()
Expand Down
Loading